Skip to content

Commit

Permalink
Improve wording
Browse files Browse the repository at this point in the history
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
  • Loading branch information
Ndpnt and MattiSG committed May 8, 2024
1 parent 9bead1c commit c396a91
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ All changes that impact users of this module are documented in this file, in the
### Changed

- Consider extraction errors as expected operational errors without crashing the engine
- Consider extraction errors as expected operational errors instead of crashing the engine

### Added

- Added label `empty content` to reported issues on GitHub when server returns empty content or when PDF content is unextractable
- Added label `invalid selector` to reported issues on GitHub when CSS selector is invalid
- Add label `empty content` to reported issues on GitHub when server returns empty content or when PDF content is unextractable
- Add label `invalid selector` to reported issues on GitHub when CSS selector is invalid

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion src/archivist/extract/errors.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export class ExtractDocumentError extends Error {
constructor(message) {
super(`The extraction cannot be done: ${message}`);
super(`Extract failed: ${message}`);
this.name = 'ExtractDocumentError';
}
}
2 changes: 1 addition & 1 deletion src/archivist/fetcher/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe('Fetcher', function () {
});
});

context('when server responds with an emtpy content', () => {
context('when server responds with empty content', () => {
const zeroContentUrl = `http://127.0.0.1:${SERVER_PORT}/zero-content`;

it('throws a FetchDocumentError error', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/archivist/services/service.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ describe('Service', () => {
});

context('with a filter', () => {
it('returns the number of filtered terms types', () => {
it('returns the number of terms matching the provided terms types', () => {
expect(subject.getNumberOfTerms([ TERMS_OF_SERVICE_TYPE, IMPRINT_TYPE ])).to.equal(1);
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/reporter/labels.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@
{
"name": "invalid selector",
"color": "FBCA04",
"description": "Selector is invalid"
"description": "Some selectors cannot be understood by the engine"
}
]

0 comments on commit c396a91

Please sign in to comment.