Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint commit messages to enforce consistency #1059

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Lint commit messages to enforce consistency #1059

merged 12 commits into from
Mar 14, 2024

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Mar 7, 2024

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules need also be documented in the CONTRIBUTING 🙂

.github/workflows/commit.yml Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@MattiSG
Copy link
Member

MattiSG commented Mar 7, 2024

04d5f54 seems to be a test commit 😉

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to trying that out! As discussed synchronously, this might be useful or just as likely very frustrating for contributors. I am curious to see if this proves useful or if we remove it 😊 Thank you for suggesting that experiment! I already like that we could update our rules to reflect reality 👍

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
.github/workflows/commit.yml Outdated Show resolved Hide resolved
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.github/workflows/commit.yml Show resolved Hide resolved
@MattiSG
Copy link
Member

MattiSG commented Mar 14, 2024

@Ndpnt do you need anything from me here?

@Ndpnt
Copy link
Member Author

Ndpnt commented Mar 14, 2024

@Ndpnt do you need anything from me here?

No, it's ok now, thanks!

@Ndpnt Ndpnt merged commit f9d9e00 into main Mar 14, 2024
9 checks passed
@Ndpnt Ndpnt deleted the add-commit-linter branch March 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants