Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix #109

Closed
wants to merge 2 commits into from
Closed

Conversation

AdamRJensen
Copy link
Contributor

The tests.yml script run on GitHub actions is already set up to support a test matrix, e.g., testing on a combination of different operating systems and versions of Python.

strategy:
matrix:
os: [ubuntu-latest]
python-version: ['3.11']

However, right now, the matrix only includes one OS and one version of Python. I suggest including all currently supported versions of Python and adding MacOS and Windows. Hopefully, all tests will simply pass, and this will be an easy modification.

@jakobhaervig
Copy link
Member

Thanks @AdamRJensen. I had trouble with Numba on Python 3.12 with Conda. More info here: numba/numba#9197

Until this is fixed, I believe its easier to stick with 3.10 and 3.11, which I tested to work :-) I'll update with windows-latest and macos-latest after some testing!

@jakobhaervig
Copy link
Member

jakobhaervig commented Feb 27, 2024

@AdamRJensen, thanks for the pr! I now tested and 3.10 wont work out of the box due to some incompatibility with Poetry. I added macos-latest and windows-latest.
Note that this action is just to test if the numerics of OpenTerrace align with analytical solutions where applicable. I should probably do a proper action to test installation in various os's. I believe this is what you suggest?

@AdamRJensen
Copy link
Contributor Author

@AdamRJensen, thanks for the pr! I now tested and 3.10 wont work out of the box due to some incompatibility with Poetry. I added macos-latest and windows-latest. Note that this action is just to test if the numerics of OpenTerrace align with analytical solutions where applicable. I should probably do a proper action to test installation in various os's. I believe this is what you suggest?
I don't see why you need poetry to run the tests? By implementing the test matrix as done in this PR you test installing the package via pip (local package) on the various platforms specified in the matrix.

@jakobhaervig
Copy link
Member

A test matrix including macos-latest and windows-latest is now added. For convenience I would like to keep Poetry as the backend instead of pip. This is now unified across all workflows. Also, the Python version is now read from pyproject.toml, which is now the only file with version numbers hardcoded.

Closing this one.

@AdamRJensen AdamRJensen deleted the patch-2 branch February 29, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants