Refactoring and quality Improvement (2)

[daisukenishino]

Requirement

These pointed out items have potential that will be refactored.

Please correct the following defects.

• No.1.

• No.2.

• No.3. fixed

• No.4. fixed

• No.5. fixed

[daisukenishino]

Naming rule

The name written Ht which means HashTable.

Pointing out

#253 (comment)

Correspondence

Ht ---> Dic

Name of asynchronous method

Pointing out

OpenTouryoProject/MultiPurposeAuthSite#85 (comment)

Correspondence

e.g. :

• private void GetUserInfo()
• private async Task GetUserInfoAsync()

[daisukenishino]

Feedback from Multi-purpose authentication site

/Controllers/ErrorController.cs

• Release work ( ~ October 1, 2017) MultiPurposeAuthSite#46 (comment)
• https://github.com/OpenTouryoProject/MultiPurposeAuthSite/blob/develop/root/programs/MultiPurposeAuthSite/MultiPurposeAuthSite/Controllers/ErrorController.cs#L158

/Infrastructure/Business/AsyncProcessingService/LayerD.cs

• Release work ( ~ October 1, 2017) MultiPurposeAuthSite#46 (comment)
• https://github.com/OpenTouryoProject/AsynchronousProcessingService/blob/develop/root/programs/CS/Frameworks/Infrastructure/Business/AsyncProcessingService/ApsLayerD.cs#L66

[daisukenishino2]

Fixed this issue by ESLint support that is added to VS2017.

null check method in JavaScript

ex: oauthimplicit.js

if (queryString == null) {

↓ ↓ ↓

if (!queryString) {

• JavaScriptの比較処理 - .NET 開発基盤部会 Wiki
  https://dotnetdevelopmentinfrastructure.osscons.jp/index.php?JavaScriptの比較処理

[daisukenishino2]

Warning occurs at build.

There is a method with the async keyword that does not execute await.

Pointing out

OpenTouryoProject/OpenTouryoTemplates#76 (comment)

Correspondence

• Under consideration of the correspondence method.
• If do not set the default to async, it will be terribly troublesome to make it async on the way.

warning MSB3277

Warning MSB3277 may occur depending on the environment.

Pointing out

OpenTouryoProject/OpenTouryoTemplates#76 (comment)

Correspondence

• Under consideration of the correspondence method.
• This may be an environmental problem.

[daisukenishino2]

Typo, etc.

ベーククラス ---> ベースクラス

OpenTouryoProject/MultiPurposeAuthSite#85 (comment)

してく下さい ---> してください

OpenTouryoProject/MultiPurposeAuthSite#85 (comment)