New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release work ( ~ October 1, 2017) #253
Conversation
- OK and YES / NO pseudo dialogs. - Business modal dialog.
- In this time, merged the previous merge leakage of the VB version.
Fixed : "The classes of FontAwesome are not recognized in ProjectX_sample." #240
Fixed : "Multiple contents applied to ContentPlaceHolder_A in testDLScreen." #238
Fixed : "Replace window.showModalDialog that is used from dialog display functions." #236
fixed WebForms of C#.
fixed WebForms of C#.
fixed MVC of C#.
Additional fix of the List<T> support to Dam.
Merged into VB version.
Added the sample code.
Changed the sample code that has some problem.
Changed the sample code to be appropriate.
Add support the nested UserControl.
- Added user controls that have not been added. - Merged into VB version, again.
/// <summary>非同期 ASP.NET WebAPI用 ベーククラス2</summary> | ||
/// <remarks>(ActionFilterAttributeとして)自由に利用できる。</remarks> | ||
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = true)] | ||
public class MyBaseApiControllerAsync : ActionFilterAttribute, IAuthenticationFilter, IActionFilter, IExceptionFilter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name should be a semantic name (what does this class do?). So, I think that the class name should not contain the word Async.
The name of asynchronous method should contain the word Async.
license/README.txt
Outdated
|
||
- OpenTouryoProject/OpenTouryoDocuments | ||
https://github.com/OpenTouryoProject/OpenTouryoDocuments | ||
- FrontPage - Open ���� Wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The writing is garbled.
Is this file encoded in Shift-JIS?
@@ -0,0 +1,39 @@ | |||
setlocal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notify developers of how to use this file in readme.
|
||
/// <summary>ユーザ情報を取得する</summary> | ||
/// <param name="authenticationContext">HttpAuthenticationContext</param> | ||
private async Task GetUserInfo(HttpAuthenticationContext authenticationContext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name the asynchronous method xxxAsync.
/// プレフィックスと | ||
/// イベント ハンドラのディクショナリ | ||
/// </returns> | ||
protected Dictionary<string, object> MyCreatePrefixAndEvtHndHt() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Ht an abbreviation for HashTable?
If so, since the type of return value is Dictionary, use Dic instead.
license/README.txt
Outdated
Open����́A2014�N4���ɃI�[�v���\�[�X�Ƃ��Č�J���ꂽ�B | ||
�����āAOpen����Project�ɂ��ăt�H�[�N���ꂽ�B | ||
Web�T�C�g�Fhttp://www.osscons.jp/dotNetDevelopmentInfrastructure/ | ||
Open棟梁は、株式会社日立ソリューションズ(Hitachi Solutions, Ltd.)の社内ツールである。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
社内ツールである -> 社内ツールとして開発された
root/README.md
Outdated
@@ -124,6 +124,9 @@ Legend: | |||
<td>3_Build_Framework.bat</td><td>Build the framework. (Base class 1 and base class 2)</td><td>○</td><td>○</td> | |||
</tr> | |||
<tr> | |||
<td>3_Build_NuGet_net47.bat</td><td>Build the framework to make NuGet package of net47. (Base class 1 )</td><td>△<span style="color: red"><sup>*4</sup></span></td><td></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build the framework to make NuGet package of net47. (Base class 1 ) -> Build the framework (Base class 1) to make NuGet package that targets .NET Framework 4.7.
root/Readme.ja.md
Outdated
@@ -115,6 +115,9 @@ Open 棟梁のプログラムをビルドするときは、**初回のみ、MSBu | |||
<td>3_Build_Framework.bat</td><td>フレームワーク部分 (ベースクラス1,2) をビルドする。</td><td>○</td><td>○</td> | |||
</tr> | |||
<tr> | |||
<td>3_Build_NuGet_net47.bat</td><td>net47 の NuGet package 作成のため、フレームワーク部分 (ベースクラス1) をビルドする。</td><td>△<span style="color: red"><sup>*4</sup></span></td><td>○</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
net47 の NuGet package 作成のため、フレームワーク部分 (ベースクラス1) をビルドする。 -> .NET Framework 4.7 をターゲットとする NuGet パッケージの作成用に、フレームワークをビルドする。
Release of 02-10 version (within 1 October 2017)