Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics: remove speed filtering. #1293

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Statistics: remove speed filtering. #1293

merged 1 commit into from
Jun 30, 2022

Conversation

dennisguse
Copy link
Member

Part of #1003.

I am kind of annoyed by all the max speed issues we have - let's start by removing stuff, we don't understand...

@dennisguse dennisguse requested a review from rgmf June 21, 2022 19:29
@dennisguse
Copy link
Member Author

@vlmendz @ae5960e8-a6fc-491f-b252-898ecf59af95 @vsevjednom-cz do you have some time to test this?
If doesn't completely misbehave, I would merge it.
And then let's see how we continue from there.

@vsevjednom-cz
Copy link
Contributor

do you have some time to test this?

Of course but please, write me how to do it automatically in Android studio. I've done it before, but I don't remember. I don't do it often.

@dennisguse
Copy link
Member Author

@vsevjednom-cz Just look for the command line instructions from GitHub
image

Copy link
Member

@rgmf rgmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a tiny thing.

@vsevjednom-cz
Copy link
Contributor

@vsevjednom-cz Just look for the command line instructions from GitHub

I'm afraid of deleting my edits and fragments 😱. Sorry.
This is sounds better: full code with code changes - do you have it somewhere?

@ae5960e8-a6fc-491f-b252-898ecf59af95

I see this hit F-Droid today. Does this change only affect new tracks? My max speeds for past tracks recorded with a Bluetooth speed sensor still show up as being almost half of what they should be.

@dennisguse
Copy link
Member Author

@ae5960e8-a6fc-491f-b252-898ecf59af95 no, you would have to export, delete, and import the tracks. Max speed is computed while storing a tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants