Mark registration profile activated when confirming invited user #3248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The registration system uses both the
activated
field in addition to theUser.is_active
fields. SettingUser.is_active
to false after activation lets us disable an account and prevent the user from reactivating it. Because of this we must also update theactivated
field.Connects #3247
Notes
Before this fix, users who accepted invitations were unable to reset their passwords because of this code:
https://github.com/OpenTreeMap/otm-core/blob/2.21.0/opentreemap/registration_backend/views.py#L211-L212
Testing Instructions
./scripts/debugserver.sh
activation-test