Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write operations should take a SHA argument that identifies their parent #58

Closed
mtholder opened this issue Feb 28, 2014 · 1 comment
Closed
Assignees
Labels

Comments

@mtholder
Copy link
Member

We are using lazy branch creation (create WIP on first write not on the GET), which seems good.
But the change set should be applied to the parent that corresponds to the version of the NexSON that the curator was looking at when he/she made the edits.
On write, we should:
1 check for WIP for this study, user, parent commit SHA

  1. if not found:
    A. checkout parent commit,
    B. create WIP from that commit,
    C. checkout WIP
  2. write new content on WIP then commit and return new SHA

The change we need is 2A (instead of checking out master, we should checkout the correct parent).

@mtholder
Copy link
Member Author

@snacktavish and I have this working on the "local-dep" branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants