Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching raw source (with Unicode) is broken #1990

Closed
trumpeta opened this issue Feb 23, 2023 · 3 comments
Closed

Fetching raw source (with Unicode) is broken #1990

trumpeta opened this issue Feb 23, 2023 · 3 comments
Labels
browser issue Surprise! It's a browser issue. bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.

Comments

@trumpeta
Copy link

What happened?

Hi, the raw source fetched using @require clause seems cut for some libraries.
I've checked the source code view at site's repository where the sources are still complete.
Not happening with all sources, just some.

What did you expect to happen?

Raw source should match source code in HTML view.

What the problem might be?

Site not sending whole source.
@trumpeta trumpeta added the bug You've guessed it... this means a bug is reported. label Feb 23, 2023
@Martii Martii added tracking upstream Waiting, watching, wanting. migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Feb 23, 2023
@Martii
Copy link
Member

Martii commented Feb 23, 2023 •
edited

Thanks for making an issue here.

Site not sending whole source.

As I mentioned on OUJS... this is proably a terser error. If you are unhappy with an over-exaggerated work-around try using just a single comment // at the tail end of the library which works for me on one of the affected libraries instead of the sensationalized:

appending about 100 to 200 comment chars

... which that many may be unnecessary.

If you find a minification error on this experimental feature of OUJS and no work-around please use the key from here.

As further notice if the code shows up in the Source Code tab on OUJS then it's exactly what is served (unminified of course) via the direct .js and .user.js routes. i.e. they use the same exact routine to retrieve.

Only reason to keep this issue open is for potential migration from terser@v4.x to terser@v5.x migration... which is a known but not issued at this time.... albeit additionally tracked at #432 .

@Martii Martii added the dependency issue Hmmph! A dependency issue label Feb 23, 2023
@Martii Martii changed the title Fetching raw source is broken Fetching (minified) raw source is broken Feb 23, 2023
@Martii Martii changed the title Fetching (minified) raw source is broken Fetching (some minified) raw source is broken Feb 23, 2023
@Martii
Copy link
Member

Martii commented Feb 26, 2023 •
edited

Okay so another user mentioned this and I guessed at the unminified target correctly. Btw I'm suprised the "work-around" works albeit it hasn't been tested completely as it really shouldn't work at all... meh... browsers.

I believe that I've found the Unicode issue. Please let me know if it's still doing it. If you do encounter it I expect a direct link to the source on OUJS so I can cross-check with it instead of guessing please so I don't have to close this as incomplete issue response.

Going to close this if no further recent issues regarding this are present. terser tracking will go back to being only #432 for the time being. Actual issue related to #200

@Martii Martii changed the title Fetching (some minified) raw source is broken Fetching raw source is broken Feb 26, 2023
@Martii Martii added browser issue Surprise! It's a browser issue. and removed tracking upstream Waiting, watching, wanting. migration Use this to indicate that it may apply to an existing or announced migration. dependency issue Hmmph! A dependency issue labels Feb 26, 2023
@trumpeta
Copy link
Author

The issue is gone, no significant chars are cut off on affected sources.

@Martii Martii changed the title Fetching raw source is broken Fetching raw source (with Unicode) is broken Feb 27, 2023
@Martii Martii closed this as completed Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser issue Surprise! It's a browser issue. bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martii @trumpeta