Soft reset #197
Closed
Soft reset #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Antagonym looks like sign commit is required, could you push signed commit ? Else please contact one of admins to manually merge tihs feature. |
|
really waiting for this fix, as it's really necessary for container environments |
|
@Antagonym I'll merge this on the condition that You can either simply agree here, or you can submit a further patch. |
TinCanTech
requested changes
Mar 23, 2022
|
In truth, I'm not sure |
TinCanTech
referenced
this pull request
Mar 31, 2022
… Antagonym-soft-reset Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
referenced
this pull request
Mar 31, 2022
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
|
Closed via 14a29f9 Default is set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what was suggested in #178.
This adds
soft-resetandhard-resetcmd-opts toinit-pkisubcommand, wherehard-resetrecursively removes the PKI directory (the current behavior) andsoft-resetonly removes most of the content, but keeps the directory and thevarsfile (as well as other user created files) intact.I decided to implement this as cmd-opts instead of a
--option, because from looking at the existing options, it seems like they are more generic or common to a family of subcommands, whereas cmd-opts seem to be specific to a single subcommand (thoughnopasswould be an exception to that rule).Note that I have made
soft-resetthe default behavior if no cmd-opt is passed, which is different from the previous behavior and may break scripts relying on this. I did this because I find this the saner option in most use-cases, but this can easily be changed if maintaining previous behavior is deemed more important.