Add revoke-renewed to revoke renewed certificate #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually if one successfully renew a certificate with renew command, a new certificate is created (and placed in pki/issue folder) while the old one is moved to pki/renewed/certs_by_serial and renamed based on its serial. The problem is that there is no easy way to revoke the previous certificate. The proposed revoke-renewed command, takes the previous certificate serial and get the previous certificate from pki/renewed/certs_by_serial folder and revoke it. Then it moves the just revoked certificate (and its associated req, key, p12...) to folders under pki/renewed_then_revoked.
This was referenced Mar 29, 2022
|
@tshikose This is a good start but it needs improvement. Example: You test for the existence of files after you have used them. |
TinCanTech
added
feedback welcome
development
|
@tshikose Thank you for your contribution. Commit ef22701 partially incorporated this PR. Unfortunately, finding a complete solution to the problem of:
required a lot of changes not covered by your PR. With apologies, it was not possible to merge this PR. However, this original PR has been logged in |
|
Closed via ef22701 |
|
Dear TinCanTech,
I thank you for your emails.
I will have a look at them and I will revert back.
Regards,
Tshimanga Minkoka
…On Tue, 2022-03-29 at 12:09 -0700, TinCanTech wrote:
@tshikose This is a good start but it needs improvement.
Example: You test for the existence of files after you have used
them.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually if one successfully renew a certificate with renew command, a new certificate is created (and placed in pki/issue folder) while the old one is moved to pki/renewed/certs_by_serial and renamed based on its serial.
The problem is that there is no easy way to revoke the previous certificate.
The proposed revoke-renewed command, takes the previous certificate serial and get the previous certificate from pki/renewed/certs_by_serial folder and revoke it.
Then it moves the just revoked certificate (and its associated req, key, p12...) to folders under pki/renewed_then_revoked.