Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renew on OpenBSD #418

Merged
merged 1 commit into from Mar 31, 2022
Merged

Fix renew on OpenBSD #418

merged 1 commit into from Mar 31, 2022

Conversation

pacija
Copy link
Contributor

@pacija pacija commented Nov 19, 2020

Change allow_renew_date so it doesn't use -v flag not present on OpenBSD version of date

@pacija
Fix renew on OpenBSD
10f6fb2 
Change `allow_renew_date` so it doesn't use `-v` flag not present on OpenBSD version of `date`
@TinCanTech TinCanTech added this to the 3.2 branch milestone Mar 16, 2022
@TinCanTech
Copy link
Collaborator

Are you able to test this on both Darwin and BSD and post the results here ?

Just paste command line date examples to show the result.

@TinCanTech TinCanTech modified the milestones: 3.2 branch, v3.1.0 Mar 30, 2022
@TinCanTech TinCanTech self-assigned this Mar 30, 2022
@TinCanTech TinCanTech requested a review from cron2 March 31, 2022 15:43
@cron2
Copy link

cron2 commented Mar 31, 2022

Looks good to me. Tested FreeBSD, NetBSD, OpenBSD, MacOS and all accept "date -j +%s".

@TinCanTech TinCanTech added Full-Approval Merge is imminent Priority Acknowledged priority and removed clarification-requested initial-approval labels Mar 31, 2022
@TinCanTech TinCanTech modified the milestones: v3.1.0, v3.0.9 Mar 31, 2022
@TinCanTech TinCanTech self-requested a review March 31, 2022 18:25
TinCanTech
TinCanTech reviewed Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@TinCanTech TinCanTech left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be merged due to incorrect indent characters, please rebase on current.

I'll sort it :-)

@TinCanTech TinCanTech merged commit 6759e87 into OpenVPN:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinCanTech TinCanTech TinCanTech left review comments

@cron2 cron2 Awaiting requested review from cron2

Assignees

@TinCanTech TinCanTech

Labels
Full-Approval Merge is imminent Priority Acknowledged priority
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacija @TinCanTech @cron2