Introduce 'rewind-renew' - Recover "guineapig" renewed certificates #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original version of EasyRSA command 'renew', leaves the certificate without a method to be revoked. This is due to 'renew' moving files OUT of the PKI, which means they cannot be targeted by command 'revoke'. Additionally, 'renew' renames the files to an unfriendly serial-number. -- Command 'rewind-renew' restores the original commonName as file-name-base. And moves these files to renewed folders which are targeted by 'revoke-renewed'. Closes: #578 (Thoroughly tested) Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Use move not copy (copy was used in development). Corrections to help and error messages. Re-arrange "hand-off" 'case'; group renew functions together. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
referenced
this pull request
Aug 20, 2022
When easyrsa "renews" a certificate, the current certificate is moved to a sub-directory for renewed certificates and renamed to the serial number of the certificate. This makes it difficult to subsequently revoke the old certificate. The new behaviour is for easyrsa to move the certificate without renaming the file. This means the certificate can be revoked by name. Once a renewed certificate is revoked, it is moved to the 'revoked' sub-directory, along with all other revoked certificates. The same mechanism also manages keys, requests, PKCS and inline files. Behaviour summary: * revoke moves certificates to 'revoked' - Unchanged Rename the certificate to its serial number - Unchanged * renew moves certificates to 'renewed' - Unchanged renew does not rename the certificate to its serial number - Changed Important: Only one certificate of a specific name (eg. john) can be renewed at the same time. To renew another certificate called 'john' the first MUST be revoked. * revoke-renewed: takes the certificate from 'renewed' - Changed moves the certifiate to 'revoked' - Changed renames the certificate to its serial number - Unchanged * All revoked certificates are moved to the 'revoked' sub-directory. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of EasyRSA command 'renew', leaves the certificate
without a method to be revoked.
This is due to 'renew' moving files OUT of the PKI, which means they cannot
be targeted by command 'revoke'.
Additionally, 'renew' renames the files to an unfriendly serial-number.
--
Command 'rewind-renew' restores the original commonName as file-name-base.
And moves these files to renewed folders which are targeted by 'revoke-renewed'.
Closes: #578 (Thoroughly tested)
Signed-off-by: Richard T Bonhomme tincantech@protonmail.com