Status Report 'show-renew': Include renewed certs from /cert_by_serial #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand 'show-renew' to include certs which have been renewed the old way. These are stored in 'renewed/certs_by_serial' and require 'rewind-renew' before they can be revoked. Also, introduce option '-v|--verbose' to make all status reports (only) more verbose. In this particular use case, verbose message detail expected serialNumber mismatches, which can then be verified. The previous code returned with out an error, even though the test suggests that an error had occurred. This verbosity for reports helps to verify that the report is correct. Manually tested on a PKI with a mix of v1/v2 style renews. Closese: 699 Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand 'show-renew' to include certs which have been renewed the old way. These are stored in 'renewed/certs_by_serial' and require 'rewind-renew' before they can be revoked.
Also, introduce option '-v|--verbose' to make all status reports (only) more verbose.
In this particular use case, verbose message detail expected serialNumber mismatches, which can then be verified. The previous code returned with out an error, even though the test suggests that an error had occurred.
This verbosity for reports helps to verify that the report is correct.
Manually tested on a PKI with a mix of v1/v2 style renews.
Closes: #699
Signed-off-by: Richard T Bonhomme tincantech@protonmail.com