Post version 3.1.5 refactor #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build-ca: * Replace 'print foo' with function create_x509_types_ca() * Replace 'ignore' with function create_x509_type_COMMON() sign-req: * Replace 'ignore' with function create_x509_type_COMMON() Note: x509-types/COMMON only has comments, no code. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Only show the "foreign request" warning when sign-req is called for an imported request. Do not show the warning when the request has been created by build-full-*. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
post-315-refactor
branch
from
f1d56d4
to
d7aa07b
Compare
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Remove fucntion-end 'retrun 0' because it masks unexpected errors. 'if; then; else; fi;' wrap SSL call. Minor improvements. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Replace use of die(), which is very noisy, with user_error(), which simply outputs the error message and EasyRSA Version. Use of user_error() is specific to input and file errors, caused by invalid user input. Internal errors continue to use die(). Other associated improvements to output. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
When commands executed in a subshell fail the error message is lost. Easy-RSA error log provides a permanent temp-file to write those error messages to and be displayed on completion of the script. This first use of the log-file by easyrsa_mktemp(), will log errors caused by requiring more than three (3) subshell temp-files. Temp-files created during a subshell command do not update the temp-file counter, so their name relies on a second, built-in extension to the temp-file name. If this second extension exceeds three (3) then a non-fatal warning is logged to the error log-file. Other functions, which are executed in subshells, will use the error log-file in follow up patches, as required. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
post-315-refactor
branch
from
83e60b7
to
06d7990
Compare
Minor improvements to help and comments Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
post-315-refactor
branch
from
06d7990
to
49fda49
Compare
This moves all PKI and CA initialisation requirements into verify_working_env(). Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Prioritise $EASYRSA_NO_VARS above other vars file detection. Rename $pki_is_required to $require_pki Re-establish; Do not require PKI, CA or vars for command 'upgrade'. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes made for general readability and ongoing maintenance.
No functional changes.