Simplify run-once control for exanding conf files #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyrsa_openssl(): Move run-control to functions easyrsa_rewrite_ssl_config() and escape_hazard(). Replaces complex control code in easyrsa_openssl(). Run-control supports: * EASYRSA_FORCE_SAFE_SSL: --force-safe-ssl, ALWAYS run. * EASYRSA_NO_SAFE_SSL: --no-safe-ssl, NEVER run. * Run-once: Default, run-once only. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Set run-once after if condition, otherwise Forced execution does not set run-once. Use "local" variable 'makesafeconf' to force a new safe ssl config. Remove variable require_safe_ssl_conf, partially replaced by makesafeconf. Add 'make-safe-ssl' command to the list which does not require a CA. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
rewrite-ssl-org-conf-files
branch
2 times, most recently
from
88b3bf9
to
416a8b1
Compare
|
416a8b1 appears to have shaved time off the unit tests.
|
TinCanTech
force-pushed
the
rewrite-ssl-org-conf-files
branch
from
416a8b1
to
ac22c65
Compare
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
rewrite-ssl-org-conf-files
branch
from
ac22c65
to
d80040b
Compare
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace complex (ugly) code in
easyrsa_opessl()with simple code in the functionseasyrsa_rewrite_ssl_conf()andescape_hazard().Subsequently, rename functions, variables and temp-file names, for simplicity and conformity.