Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dns options don't work on Windows with tap-windows6 driver #447

Closed
lstipakov opened this issue Nov 10, 2023 · 0 comments
Closed

--dns options don't work on Windows with tap-windows6 driver #447

lstipakov opened this issue Nov 10, 2023 · 0 comments
Assignees
@lstipakov

Comments

@lstipakov
Copy link
Member

When server pushes dns server 0 address 8.8.8.8 (or any other --dns option) and client uses tap-windows6 driver, those options have no effect on the client side.

This is because tap-windows6 uses DHCP, and client sends DHCP string to the driver if tuntap_options::dhcp_options field is set. However, this is done only for --dhcp-options and not for --dns.
@lstipakov lstipakov self-assigned this Nov 10, 2023
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 10, 2023
@lstipakov
Make --dns options apply for tap-windows6 driver
552d140 
When tap-windows6 driver is used, both --dhcp-option and
--dns options are applied with DHCP. When processing --dns options,
we don't set "tuntap_options.dhcp_options" member, which is required
for DHCP string to be sent to the driver. As a result, --dns options
are not applied at all.

Fix by adding missing assignment of tuntap_options.dhcp_options.

Fixes OpenVPN#447

Change-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7
Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 10, 2023
@lstipakov
Make --dns options apply for tap-windows6 driver
df4acf0 
When tap-windows6 driver is used, both --dhcp-option and
--dns options are applied with DHCP. When processing --dns options,
we don't set "tuntap_options.dhcp_options" member, which is required
for DHCP string to be sent to the driver. As a result, --dns options
are not applied at all.

Fix by adding missing assignment of tuntap_options.dhcp_options.

Fixes OpenVPN#447

Change-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7
Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 10, 2023
@lstipakov
Make --dns options apply for tap-windows6 driver
02b6a87 
When tap-windows6 driver is used, both --dhcp-option and
--dns options are applied with DHCP. When processing --dns options,
we don't set "tuntap_options.dhcp_options" member, which is required
for DHCP string to be sent to the driver. As a result, --dns options
are not applied at all.

Fix by adding missing assignment of tuntap_options.dhcp_options.

Fixes OpenVPN#447

Change-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7
Signed-off-by: Lev Stipakov <lev@openvpn.net>
cron2 pushed a commit to cron2/openvpn that referenced this issue Nov 15, 2023
@lstipakov @cron2
Make --dns options apply for tap-windows6 driver
0acba3c 
When tap-windows6 driver is used, both --dhcp-option and
--dns options are applied with DHCP. When processing --dns options,
we don't set "tuntap_options.dhcp_options" member, which is required
for DHCP string to be sent to the driver. As a result, --dns options
are not applied at all.

Fix by adding missing assignment of tuntap_options.dhcp_options.

Github: fixes OpenVPN/openvpn#447

Change-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20231115120623.6442-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27402.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 60def50)
@cron2 cron2 closed this as completed in 60def50 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstipakov lstipakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lstipakov