Implement server_poll_timeout for socks instead of hard-coded 5 sec #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have been struggling to run openvpn over slow proxies.
There was a bug #328 submitted 10 years ago.
To fix this, the server-poll-timeout config value was introduced, but has only been implemented for http proxies.
For socks the timeouts are still hard-coded to 5 sec.
That's why people are still having problems, see issue #267
I submitted a patch to the mailing list, but since this was my first time using a mailing list over git, I failed to provide details in the mail.
With this patch, establishing a socks connection uses the timeout set by server-poll-timeout (default: 120s).
I used the same logic like it was implemented for http proxies, which includes the socks handshake for the timeout.
So here's a PR with more details, in hope that it gets reviewed and implemented soon.