Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

management interface: Reverted management_io to its original state to prevent the following problem: #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

management interface: Reverted management_io to its original state to prevent the following problem: #46

wants to merge 1 commit into from
+4 −1

Commits on May 17, 2016

  1. Reverted management_io to its original state to prevent the following 

    problem:
man_read -> ... -> man_output_list_push_finalize -> management_io ->
man_read

After some digging I found this commit made by James Yonan in 2010:
https://sourceforge.net/p/openvpn/openvpn-testing/ci/3cf6c9328250061600b78c8a7deb0edc850e739b

In this commit he put both writing to and reading from the socket into the
same "if" branch, which leads to the problem I've mentioned above.
man_read after having been called recursively goes nuts and screws its input
buffer, as result openvpn can processes the same command several times
and then fail to read the rest of them correctly.

I'm not sure that what I did here is the best way to solve this problem,
but it seems to work for me.
    @amatveyev-gh
    amatveyev-gh committed May 17, 2016
    Configuration menu
    Copy the full SHA
    3ca6ae2 View commit details
    Browse the repository at this point in the history