Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Fix provider vs current APIs #136

Merged
merged 7 commits into from
May 2, 2024

Conversation

chicco785
Copy link
Contributor

@arslanbekov is a working in progress based on changes to the client.

happy to have a chat around this

.env.example Show resolved Hide resolved
@@ -0,0 +1,104 @@
package client
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may it is better to have something like this in https://github.com/OpenVPN/cloudconnexa-go-client

@chicco785 chicco785 marked this pull request as ready for review April 24, 2024 12:01
@chicco785
Copy link
Contributor Author

changes to the provider have been tested for few use cases, most probably there are other fixes needed, e.g.:

  • updating a network by changing the route is not working correctly;
  • destroy a ip_service (if it's the only one attached to a network) is not working (but this is more a logic problem at the api level), despite you destroy also the connected network (maybe playing with lifecycles will make it work, not sure).

@chicco785 chicco785 changed the title WIP: Fix provider Fix provider vs current APIs Apr 24, 2024
@arslanbekov
Copy link
Member

@chicco785 Thank you for this. Very valuable!

@arslanbekov arslanbekov merged commit d82b572 into OpenVPN:main May 2, 2024
2 of 4 checks passed
This was referenced May 2, 2024
@chicco785 chicco785 deleted the fix-provider branch May 3, 2024 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants