Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for stereo input (ROS2) #41

Merged
merged 5 commits into from
Mar 8, 2021

Conversation

mirellameelo
Copy link
Contributor

Hi. The changes are the following:

  • adding the support for stereo input (ROS2)
  • using ROS simulation time instead of system time
  • printing msgs with RCLCPP_INFO instead of std::cout
  • changing the publisher's topic to match with the subscriber's topic.

@mirellameelo mirellameelo changed the title Adding stereo support for ros2 Adding support for stereo input (ROS2) Mar 4, 2021
Copy link
Contributor

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's some formatting issues but those exist before you

ros/2/src/openvslam/src/openvslam_ros.cc Show resolved Hide resolved
ros/2/src/openvslam/src/openvslam_ros.cc Outdated Show resolved Hide resolved
ros/2/src/openvslam/src/run_slam.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an admin here, but LGTM on the first-order level, #38 obviously has some more steps in it but this seems like a very reasonable first one

@ymd-stella
Copy link
Contributor

ymd-stella commented Mar 6, 2021

Please apply clang-format.
I often use the following command.

DIRS_TO_EXCLUDE=".git 3rd cmake docs build .idea cmake-build-debug cmake-build-release"
for DIR in ${DIRS_TO_EXCLUDE}; do
    EXCLUDE_CMD="${EXCLUDE_CMD} -type d -name ${DIR} -prune -o"
done
FILES=$(find . ${EXCLUDE_CMD} -type f -regex ".*\.\(c\|h\|cc\|hh\|cpp\|hpp\)" -print)
for FILE in ${FILES}; do
    clang-format-6.0 -style=file -i ${FILE}
done

@ymd-stella ymd-stella merged commit 1e57191 into stella-cv:main Mar 8, 2021
ymd-stella added a commit to stella-cv/stella_vslam_ros that referenced this pull request Mar 8, 2021
Arthur-CWW pushed a commit to Arthur-CWW/stella_vslam_melodic that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants