Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryQuitMainloop can return, so clean-up properly if it does. Factor o… #187

Merged
merged 1 commit into from Aug 28, 2017
Merged

TryQuitMainloop can return, so clean-up properly if it does. Factor o… #187

merged 1 commit into from Aug 28, 2017

Conversation

original-birdman
Copy link
Contributor

@original-birdman original-birdman commented Aug 27, 2017 •
edited

…ut common code to new NSCommon class to achieve this.

@original-birdman
TryQuitMainloop can return, so clean-up properly if it does. Factor o…
d40fa78 
…ut common code to new NScommon class to achieve this.
@original-birdman
Copy link
Contributor Author

original-birdman commented Aug 27, 2017 •
edited

There were several (9) classes with many (12) mostly-identical functions. These have been moved to a single NSCommon class. A reboot_at_end member was added to handle the differences between behaviour.
The fix (to tidy up if self.session.open(TryQuitMainloop, 2) returns) was then added here, in one place.

@Huevos Huevos merged commit 29a0b6f into OpenViX:Dev Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@original-birdman @Huevos