Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change primetime to left edge #561

Closed
wants to merge 1 commit into from

Conversation

AbuBaniaz
Copy link
Contributor

Change primetime to set the time of the left hand edge of the grid EPG

@AbuBaniaz AbuBaniaz closed this Jul 2, 2020
@Huevos
Copy link
Contributor

Huevos commented Jul 2, 2020

The primetime should be shown allowing for the amount of history that the user asked to be displayed!

Randomly jumping to some point against the wishes of the user is not a good approach.

All these changes and settings need to obey the user's selection for the "Maintain old EPG data for" EPG configuration.

@AbuBaniaz
Copy link
Contributor Author

I have already cherry picked this bug fix. Simone had added it to his epg custom button branch.

Thread here:
https://www.world-of-satellite.com/showthread.php?62860-Wrong-Primetime

I had submitted a pull request so it is in the queue of commits to be added while we await migration to new branch. As other commits have started going in, I added it.

@AbuBaniaz AbuBaniaz deleted the dev-primetime branch July 2, 2020 16:05
@Huevos
Copy link
Contributor

Huevos commented Jul 3, 2020

Sorry, not sure what you mean about a queue but this commit can't be used.

@AbuBaniaz
Copy link
Contributor Author

No problem. Feel free to revert the commit and leave bug in place.

@SimonCapewell
Copy link
Contributor

Happy for this to be reverted, but I'm out of ideas now regarding the bug report about primetime not behaving as expected.

@Huevos
Copy link
Contributor

Huevos commented Jul 3, 2020

This is like the multi-bouquets bug. First we need a clear list of steps to reproduce the bug. Without that we don't have a lot of hope except finding by brute force. Could it be something to do with program length?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants