Support reading from pipe #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support of reading from pipe. Sample app expects -i stdin and -n [FrameToBeEncoded] to be set. Signed-off-by: Jun Tian <jun.tian@intel.com>
tianjunwork
force-pushed
the
pipe_support
branch
from
2375012
to
aa51e71
Compare
hassount
approved these changes
Oct 28, 2018
README.md
Outdated
| @@ -105,6 +105,7 @@ In order to run the highest resolution supported by the encoder, at least 64GB o | |||
| - On any of the Windows* Operating Systems listed in the OS requirements section, install Visual Studio 2017 | |||
| - Once the installation is complete, copy the binaries to a location making sure that both the sample application “ebHevcEncApp.exe” and library “ebHevcEncLib.dll” are in the same folder. | |||
| - Open the command prompt window at the chosen location and run the sample application to encode. | |||
| - Sample application supports reading from pipe. E.g. ffmpeg -i [input.mp4] -nostdin -f rawvideo -pix_fmt yuv420p - | ebHevcEncApp.exe -i stdin -n [number_of_frames_to_encode]. | |||
There was a problem hiding this comment.
The width and height should still be specified in the SVT command line
README.md
Outdated
| @@ -127,6 +128,7 @@ For the binaries to operate properly on your system, the following conditions ha | |||
| - Change the permissions on the sample application “HevcEncoderApp” executable by running the command: chmod +x HevcEncoderApp | |||
| - cd into your chosen location | |||
| - Run the sample application to encode. | |||
| - Sample application supports reading from pipe. E.g. ffmpeg -i [input.mp4] -nostdin -f rawvideo -pix_fmt yuv420p - | ./HevcEncoderApp -i stdin -n [number_of_frames_to_encode]. | |||
There was a problem hiding this comment.
The width and height should still be specified in the SVT command line
Signed-off-by: Jun Tian <jun.tian@intel.com>
hassount
approved these changes
Oct 29, 2018
|
I am ok with this being merged, @lijing0010 ? |
|
Looks good to me
|
|
@hassount Thx for merging the change. All related commits on a pull request can be squashed as one commit when merged into mainline. Just choose "Squash Merge". |
|
whoops, should I revert then squash and merge ? |
|
I think it's ok for this one. Your call:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For linux OS, add support to read from pipe.
Sample app expects FrameToBeEncoded(-n) to be set.
Signed-off-by: Jun Tian jun.tian@intel.com