fix/deactivate_in_converse/fallback #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid the caveats documented in OpenVoiceOS/ovos-core#451
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #199 +/- ##
======================================
Coverage ? 53.63%
======================================
Files ? 36
Lines ? 3826
Branches ? 0
======================================
Hits ? 2052
Misses ? 1774
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
May 4, 2024
avoid the caveats documented in #451 companion to OpenVoiceOS/OVOS-workshop#199
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
May 4, 2024
* fix/deactivate_in_converse/fallback avoid the caveats documented in #451 companion to OpenVoiceOS/OVOS-workshop#199 * improve tests to account for message order * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid the caveats documented in OpenVoiceOS/ovos-core#451