Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/DatabaseApi #30

Merged
merged 2 commits into from
Jun 8, 2023
Merged

feat/DatabaseApi #30

merged 2 commits into from
Jun 8, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 30, 2023

companion to OpenVoiceOS/ovos-personal-backend#51

adds the new DatabaseApi for direct manipulations of databases, for offline backend this will manage relevant config files or use json databases

the json databases removed from backend were moved here, this package used to contain a reimplementation using json_database package directly

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@27d66f8). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #30   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      14           
  Lines          ?    2558           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    2558           
  Partials       ?       0           

@JarbasAl JarbasAl marked this pull request as draft March 31, 2023 12:10
@JarbasAl JarbasAl requested review from emphasize, builderjer and a team April 7, 2023 01:05
@JarbasAl JarbasAl added the enhancement New feature or request label Apr 7, 2023
@JarbasAl JarbasAl marked this pull request as ready for review April 7, 2023 01:05
@JarbasAl JarbasAl changed the title migrate json db utils feat/DatabaseApi Apr 7, 2023
requirements/offline.txt Outdated Show resolved Hide resolved
'audio': BytesIO(byte_data),
'metadata': StringIO(json.dumps(params))
}
return self.post(upload_url, files=ww_files)
Copy link
Member

@emphasize emphasize Apr 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mentioned the header problem earlier. we can not send any content_type (if posted this way). The correct type will be chosen.

The files have to be sent as multipart/form-data. The problem with that is that this type has a boundary extension associated (like Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryzuW5nPZQFQCwQtg4), which is generated automatically by requests, but not if we predefine it as multipart/form-data

Otherwise flask.request.files has no clue what is sent and return an empty ImmutableMultiDict

This issue is about postman, but the same applies here

Annoying problem and more time spent on it than i care to admit. And i'd say toss this and post it like stt data.

Copy link
Member Author

@JarbasAl JarbasAl Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a separate PR coordinated with a companion PR in personal backend (for both STT and WW)

readme

pass credentials to base backend object

optional OPM

manual version bump - signal breaking change to accompany personal-backend new features

fix headers

fix license tests

fix unittests

consistency

SkillSettingsApi for personal/selene

cleanup DeviceApi/DatasetApi + add SkillSettingsApi

fix Configuration.get (#32)

SkillSettingsApi

old Api classes deprecation logs

cleanup skill settings model + missing DatasetApi - dataset_upload_stt_recording for consistency

add DatabaseApi

offline oauth

CRUD

offline backend - recording "upload"

offline backend - recording "upload"

offline backend - skill settings

offline backend - ww/voice definitions

cleanup json modules

add some database endpoints for offline backend

database api base

undo location stuff and renaming

migrate json db utils
@JarbasAl JarbasAl merged commit 6e78ac8 into dev Jun 8, 2023
7 checks passed
@JarbasAl JarbasAl deleted the feat/local_dbs branch June 8, 2023 00:06
JarbasAl added a commit that referenced this pull request Jun 8, 2023
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants