Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/tts_mode #128

Merged
merged 1 commit into from Jun 2, 2022
Merged

Conversation

NeonJarbas
Copy link

allow audio service to load even if there are no audio backend plugins

We always want the voice assistant to be able to speak, even if skills can not play music

to test uninstall all audio backend plugins and run the audio service. confirm you still have TTS

allow audio service to load even if there are no audio backend plugins

We always want the voice assistant to be able to speak, even if skills can not play music
@JarbasAl JarbasAl added bug Something isn't working refactor code refactor without functional changes labels Jun 2, 2022
@JarbasAl JarbasAl requested review from NeonDaniel and j1nx June 2, 2022 14:07
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #128 (b536de8) into dev (6ceb058) will increase coverage by 2.94%.
The diff coverage is 34.87%.

@@            Coverage Diff             @@
##              dev     #128      +/-   ##
==========================================
+ Coverage   50.35%   53.29%   +2.94%     
==========================================
  Files         119      149      +30     
  Lines       10077     9080     -997     
==========================================
- Hits         5074     4839     -235     
+ Misses       5003     4241     -762     
Impacted Files Coverage Δ
mycroft/api/__init__.py 30.24% <0.00%> (-47.99%) ⬇️
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1027bf4...b536de8. Read the comment docs.

@JarbasAl JarbasAl merged commit bd089ec into OpenVoiceOS:dev Jun 2, 2022
@NeonJarbas NeonJarbas deleted the refactor/tts_mode branch June 8, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor code refactor without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants