Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency/imports clean up #291

Merged
merged 15 commits into from
Mar 8, 2023
Merged

dependency/imports clean up #291

merged 15 commits into from
Mar 8, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 3, 2023

@JarbasAl JarbasAl added the refactor code refactor without functional changes label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited

Codecov Report

Merging #291 (733a729) into dev (6ceb058) will increase coverage by 1.43%.
The diff coverage is 43.25%.

@@            Coverage Diff             @@
##              dev     #291      +/-   ##
==========================================
+ Coverage   50.35%   51.78%   +1.43%     
==========================================
  Files         119      156      +37     
  Lines       10077     8228    -1849     
==========================================
- Hits         5074     4261     -813     
+ Misses       5003     3967    -1036
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 161 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review March 3, 2023 20:26
@JarbasAl JarbasAl changed the title Refactor/bump ovos utils dependency/imports clean up Mar 3, 2023
@JarbasAl JarbasAl mentioned this pull request Mar 3, 2023
Closed
93 tasks
@NeonDaniel
Copy link
Member

The ovos-utils changes appear to cause problems with my config patching NeonGeckoCom/neon-utils#421

Can this be pushed to the next release?

@NeonDaniel NeonDaniel mentioned this pull request Mar 8, 2023
Merged
@NeonDaniel
Copy link
Member

Needs OpenVoiceOS/ovos-utils#104 and a dependency version bump

@JarbasAl JarbasAl merged commit 3b17c29 into dev Mar 8, 2023
@JarbasAl JarbasAl deleted the refactor/bump_ovos_utils branch March 8, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

@ChanceNCounter ChanceNCounter Awaiting requested review from ChanceNCounter

Assignees

@NeonDaniel NeonDaniel

Labels
refactor code refactor without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JarbasAl @NeonDaniel