-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ovos_conf from ovos_utils #34
feat/ovos_conf from ovos_utils #34
Conversation
logic moved to ovos_utils OpenVoiceOS/ovos-utils#12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test; left some comments for consideration
|
||
from mock_msm import \ | ||
MycroftSkillsManager as MockMSM, \ | ||
SkillRepo as MockSkillRepo | ||
|
||
from ovos_utils.configuration import get_xdg_base | ||
from mycroft.util.file_utils import get_temp_path | ||
from mycroft.util.log import LOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this import from ovos?
@@ -249,7 +250,7 @@ def upload(self): | |||
LOG.debug('settingsmeta.json not uploaded - device is not paired') | |||
|
|||
if not synced and not self._stopped: | |||
self.upload_timer = Timer(ONE_MINUTE, self.upload) | |||
self.upload_timer = Timer(60, self.upload) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ONE_MINUTE variable be deprecated?
logic moved to ovos_utils OpenVoiceOS/ovos-utils#12