Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/pipeline_plugins #349

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

feat/pipeline_plugins #349

wants to merge 6 commits into from

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 20, 2023

deprecations:

  • move adapt bus handlers from IntentService to adapt plugin
  • move padatious bus handlers from IntentService to padatious plugin
  • subclass all services from plugins (converse/fallback/common_qa)
  • add backward compatible properties with deprecation logs
  • keep old handlers around with deprecation logs in case some downstream is calling them directly

plugins:

core plugins (part of ovos-core):

  • converse
  • common_qa
  • common_play (TODO - simplify OCP and add a component to handle OCP queries instead of relying in a registered intent via OCP plugin)
  • fallback

pipeline considerations:

  • need at least 1 of adapt/exact for keyword intents (adapt in classic mycroft)
  • need at least 1 of padatious/padacioso/jurebes/padaos/exact for utterance intents (padatious in classic mycroft)
  • exact_matches can work as a slower replacement to adapt bundled in ovos-classifiers (a direct dependency) -> adapt now fully optional
  • padacioso can work as a slower replacement to padacioso (a direct dependency) -> padatious now fully optional
  • for exact matches only, padaos should perform better than exact or padacioso
  • pure regex intents, mk2 style -> new decorator needed in ovos-workshop to support registering these intents -> currently needs skills to emit bus events directly -> avoid plugin for now

@JarbasAl JarbasAl added the enhancement New feature or request label Sep 20, 2023
JarbasAl added a commit to OpenVoiceOS/ovos-classifiers that referenced this pull request Sep 20, 2023
heuristic pipeline component that ensures exact matches

companion to OpenVoiceOS/ovos-core#349
JarbasAl added a commit to OpenVoiceOS/padacioso that referenced this pull request Sep 20, 2023
provide native ovos pipeline plugin, companion to OpenVoiceOS/ovos-core#349
JarbasAl added a commit to OpenVoiceOS/padacioso that referenced this pull request Sep 20, 2023
provide native ovos pipeline plugin, companion to OpenVoiceOS/ovos-core#349
JarbasAl added a commit to OVOSHatchery/ovos-intent-plugin-padaos that referenced this pull request Sep 20, 2023
bye padacioso service, you never made it into a stable release

api compat for PadatiousService - ensure existing code remains valid syntax

api compat for AdaptService - ensure existing code remains valid syntax

move to deprecated mycroft module (for import compat only, unused in intent service)

deprecated stuff cleaning up

keep the junk in isolated classes easy to remove later on

no_side_effects

new base classes

padatious handlers in padatious service

adapt deprecation logs

adapt handlers in adapt plugin

deprecation logs everywhere - part 1
@JarbasAl JarbasAl added this to the 0.0.9 milestone Sep 30, 2023
@JarbasAl JarbasAl modified the milestones: 0.0.9, 0.1.0 Feb 22, 2024
@JarbasAl JarbasAl modified the milestones: 0.1.0, 0.2.0 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant