Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove pyxdg #53

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Refactor/remove pyxdg #53

merged 1 commit into from
Feb 15, 2022

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Feb 14, 2022 •
edited by JarbasAl

needs OpenVoiceOS/ovos-utils#21

together with #52 closes #51

other repos also need this change

@JarbasAl JarbasAl mentioned this pull request Feb 14, 2022
Closed
14 tasks
@NeonJarbas NeonJarbas mentioned this pull request Feb 14, 2022
Merged
@JarbasAl
Copy link
Member

added workflow to validate license in every PR https://github.com/NeonJarbas/ovos-core/runs/5188268536?check_suite_focus=true

NeonDaniel
NeonDaniel reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test with updated ovos-utils. left one reply, otherwise changes look okay

mycroft/skills/event_scheduler.py Outdated Show resolved Hide resolved
@JarbasAl JarbasAl added the refactor code refactor without functional changes label Feb 15, 2022
@JarbasAl
Copy link
Member

closes #51

see https://github.com/NeonJarbas/ovos-core/runs/5203358862?check_suite_focus=true

@NeonJarbas NeonJarbas force-pushed the refactor/remove_pyxdg branch 2 times, most recently from bc74989 to 68b75f1 Compare February 15, 2022 16:40
@JarbasAl JarbasAl merged commit 0d8c189 into OpenVoiceOS:dev Feb 15, 2022
@NeonJarbas NeonJarbas deleted the refactor/remove_pyxdg branch February 24, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarbasAl JarbasAl JarbasAl left review comments

@NeonDaniel NeonDaniel Awaiting requested review from NeonDaniel

Assignees
No one assigned
Labels
refactor code refactor without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copyleft detected - list of deps & util to detect them
3 participants
@NeonJarbas @JarbasAl @NeonDaniel