Initial React GUI support #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #26 +/- ##
======================================
Coverage ? 52.73%
======================================
Files ? 11
Lines ? 1022
Branches ? 0
======================================
Hits ? 539
Misses ? 483
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@alexisdiaz008 I think this is a good starting point for react support on the core side |
JarbasAl
reviewed
Aug 2, 2023
NeonDaniel
commented
Sep 1, 2023
| @@ -44,6 +44,8 @@ def get_file_extension(framework: str) -> str: | |||
| """ | |||
| if framework in ("qt5", "qt6"): | |||
| return "qml" | |||
| if framework == "react": | |||
There was a problem hiding this comment.
Are there different versions or flavors we should support here?
36 tasks
Add core messagebus event forwarding to support current react GUI implementation https://github.com/alexisdiaz008/react-mycroft-gui/blob/master/src/components/mycroft_message_bus_elements/mycroft_message_bus.jsx
NeonDaniel
force-pushed
the
FEAT_ReactGuiSupport
branch
from
e39575c
to
7d6c523
Compare
Troubleshooting react relative resource paths Minor jsx changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file extension mapping for react GUI
Add core messagebus event forwarding to support current react GUI implementation https://github.com/alexisdiaz008/react-mycroft-gui/blob/master/src/components/mycroft_message_bus_elements/mycroft_message_bus.jsx