house cleaning #39
house cleaning #39
Conversation
| self.core_bus.emit(Message("gui.namespace.removed", | ||
| data={"skill_id": namespace.skill_id})) | ||
| if self.active_extension == "Bigscreen": |
There was a problem hiding this comment.
extension unmaintained, bigscreen dropped support for OVOS and moved to QT6
can revisit once we have a dedicated bigscreen build
There was a problem hiding this comment.
Left some comments addressing breaking changes/test failures.
I believe the test_remove_pages test case also needs to be updated to use GuiPage objects instead of str which wasn't valid before but was passing since nothing in the code referenced the removed pages
|
can we just call this 0.1.0aX? removing unused code that is not meant to be used as a library is not really a breaking change as there is nothing to break, but we can still take the chance to signal those changes and move forward to proper semver, good timing to come along with core 0.0.8 stable |
refactor in follow up PR
NeonJarbas
force-pushed
the
refactor/housecleaning
branch
from
8b25f8b
to
3578f6c
Compare
ovos_gui/namespace.py
Outdated
| @@ -981,6 +1005,7 @@ def handle_namespace_global_back(self, message: Optional[Message]): | |||
| Handles global back events from the GUI. | |||
| @param message: the event sent by the GUI | |||
| """ | |||
| # TODO - unused ? missing bus event ? | |||
There was a problem hiding this comment.
seems to be a listener for "mycroft.gui.screen.close"
now allows core/gui to restart and load independently of each other
…-core refactor classes
GUI PROTOCOL -handle_delete_pagereading wrong message.data kwarg