Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/arch_support #59

Merged
merged 14 commits into from Feb 29, 2024
Merged

feat/arch_support #59

merged 14 commits into from Feb 29, 2024

Conversation

JarbasAl
Copy link
Member

still untested, need to verify all package names!

closes #58

@JarbasAl JarbasAl added the enhancement New feature or request label Feb 28, 2024
@JarbasAl JarbasAl self-assigned this Feb 28, 2024
@goldyfruit goldyfruit added this to the Doom milestone Feb 28, 2024
@JarbasAl JarbasAl marked this pull request as ready for review February 28, 2024 23:59
@JarbasAl
Copy link
Member Author

JarbasAl commented Feb 29, 2024

image
image

tested with venv / containers both install and uninstall with all combos of hivemind/ovos/gui

only didnt test voice sat

Copy link
Member

@builderjer builderjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for me. I tested installation into a venv with a gui and had no errors.

I few things with the installer in general

  • I would like to be able to pick where my venv is
  • It moves my existing ~/.config/mycroft/mycroft.conf instead of using it, or at least asking to use it
  • it also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something

Overall, this works as intended, just not like I would like

@goldyfruit
Copy link
Member

goldyfruit commented Feb 29, 2024

  • I would like to be able to pick where my venv is

Many people doesn't know what a venv is, this is prone to user error.

  • It moves my existing ~/.config/mycroft/mycroft.conf instead of using it, or at least asking to use it

We discussed this point on Matrix, if the user change the mcyroft.conf then the installer backups the file (in ~/.config/mycroft/) but restore the original to avoid user's breaking change.

  • it also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something

99% of the user will not have existing ovos-*.service in ~/.config/systemd/user/ directory. The installer will not use existing files as they might be totally different of what the installer is expecting.

@builderjer
Copy link
Member

I agree with these, especially the venv. But if there are existing files, the user must know they are there, so there should at least be a prompt or verification that they are getting moved/overwritten

@JarbasAl
Copy link
Member Author

  • t also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something

IMHO this is intended, if its doing a reinstall on top of an existing one most likely something is broken or outdated, and if the user then runs this installer on top then that is what gets the user back into a working state.

people who made their own service files either know what they are doing and dont want to use installer at all, or are noobs who followed some script or advice they didnt understand and now dont have a working ovos install

@goldyfruit
Copy link
Member

goldyfruit commented Feb 29, 2024

I agree with these, especially the venv. But if there are existing files, the user must know they are there, so there should at least be a prompt or verification that they are getting moved/overwritten

Just added a backup option, if files exist and there is a change in it, then the file will be backup.

0505c2e

@goldyfruit goldyfruit merged commit 87541c6 into main Feb 29, 2024
3 checks passed
@goldyfruit goldyfruit deleted the feat/arch_support branch February 29, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Manjaro/Arch/Endeavour
3 participants