New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor requirements to read from files #15
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
colour~=0.1 | ||
rapidfuzz~=1.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
mycroft-messagebus-client~=0.9.1,!=0.9.2,!=0.9.3 | ||
inflection~=0.5 | ||
pexpect~=4.8 | ||
requests~=2.26 | ||
json_database~=0.6 | ||
kthread~=0.2 | ||
pyxdg~=0.27 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was supposed to be swapped for xdg and some manual code because LGPL There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is the package spec'd in ovos-core and mycroft-core.. refactoring this should be fine, but just a note that it adds another dependency to most installations. I think the refactor will also require some code changes and thus be out of scope for this PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's probably worth escalating, considering. |
||
PyYAML~=5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Splainit? I believe you, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.9.2 and 0.9.3 had the questionable license change; it probably doesn't matter since it was later resolved, but Mycroft blacklisted those versions from their own code, so I got in the habit of doing the same..
Ignoring license, this probably could be
~=0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I didn't make the connection.