-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: current practices #8
Conversation
im ok with merging as is but left a couple comments
|
I'll make the updates from the comments |
Can you elaborate more on this? |
the method at bottom of the file is no longer needed, now the skill class is auto detected + also provided in setup.py that function at end of the file is just dead code more or less, we init skill classes directly whenever possible the only use for this method would be if you had multiple skill classes in a single package and wanted to do add some logic in there to decide what to load |
Updates the hello-world skill to use the latest imports and practices as I understand them from the Matrix chat and current documentation.
Also adds a generic Python .gitignore and thus deletes the dist/ and build/ folders and all their extras.