Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workflows to include the header files in the artifact #759

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Mariosmsk
Copy link
Member

No description provided.

@Mariosmsk
Copy link
Member Author

Can you merge this, @LRossman, @eladsal? It updates the artifact with the latest header files, and users avoid the effort of searching for them.

@LRossman LRossman merged commit 029b441 into OpenWaterAnalytics:dev Mar 14, 2024
4 checks passed
@LRossman
Copy link
Collaborator

@Mariosmsk after merging your workflows commit my subsequent PR failed the continuous-integration/appveyor/branch test for 32-bit windows with the error messages shown below (the 64-bit build and test was successful as was the continuous-integration/appveyor/pr test).

  Generating Code...
  test_toolkit.vcxproj -> C:\projects\epanet\buildprod\bin\Release\test_toolkit.exe
  Building Custom Rule C:/projects/epanet/CMakeLists.txt
cd %EPANET_HOME%
tools\before-test.cmd %PLATFORM% %REF_BUILD_ID% %SUT_BUILD_ID% %APPVEYOR_REPO_COMMIT%
INFO: Staging files for regression testing
curl: (6) Could not resolve host: github.com
curl: (6) Could not resolve host: github.com
ERROR: The system cannot find the file specified.
examples.zip
System ERROR:
The system cannot find the file specified.
ERROR: The system cannot find the file specified.
benchmark.zip
System ERROR:
The system cannot find the file specified.
ERROR: The system cannot find the file specified.
benchmark.zip
System ERROR:
The system cannot find the file specified

I'm assuming the failure has something to do with the update you made to the workflows files. Could you please look into this and see if you can find what the problem might be. Thanks.

P.S. Why is there both a continuous-integration/appveyor/branch and continuous-integration/appveyor/pr test -- they seem to be doing the same thing.

@Mariosmsk
Copy link
Member Author

Hi @LRossman, I think is something different because I made changes only on GitHub workflows. However, I will make a new pull request to update the workflows to avoid the warnings and I will check it.

image

@Mariosmsk
Copy link
Member Author

Important updates
A single continuous-integration/appveyor GitHub commit status was replaces with two separate statuses: continuous-integration/appveyor/branch and continuous-integration/appveyor/pr for regular “push” and PR builds respectively.

https://www.appveyor.com/updates/2015/11/06/

@Mariosmsk Mariosmsk mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants