Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus and submenus need enable property #85

Closed
smalers opened this issue May 8, 2020 · 4 comments
Closed

Menus and submenus need enable property #85

smalers opened this issue May 8, 2020 · 4 comments
Assignees
Labels
bug Something isn't working high Priority: next release if possible XS Size: 2 hours or less

Comments

@smalers
Copy link
Contributor

smalers commented May 8, 2020

The latest push has enabled property on submenus. However, I did not have in my app-config.json file. The behavior in this case was that no submenus showed. Also, setting to false does not seem to work. The behavior should be as follows:

  • enabled should default to true if not in the config file
  • the property should be a boolean rather than a string if possible
  • a value of false should still display the menu but it should be grayed out - this will allow new features to be laid out for demonstration purpose and functionality filled in
  • to not show a menu, a property visible should be added with default true and false will not display the menu item at all - this is lower priority
@smalers smalers added bug Something isn't working high Priority: next release if possible XS Size: 2 hours or less labels May 8, 2020
@Nightsphere
Copy link
Collaborator

I just pushed for this issue. The enabled property has now been implemented so that it doesn't
need to be included, and defaults to true. Only saying enabled: "false" will gray out the
button and nothing will happen when clicked.

visible has also been implemented. Default is all menus will be visible, unless visible: "false"
is added to the menu in the config file. I would close this but first wanted to check about the use
of the true and false values as strings and not booleans. I was used to having to deal with
properties as strings because that's how the GeoProcessor created them, but since the
app-config file isn't, then it's okay to make them booleans instead?

If so, it'll take 5 minutes to update this and I'll do a new push and close the issue.

@Nightsphere
Copy link
Collaborator

After talking with Steve, a new implementation has been added for having the enabled property be set
as a boolean or a string. Either will work. Closing this issue.

@smalers
Copy link
Contributor Author

smalers commented May 21, 2020

The disabled menus need to have their appearance changed. The graying of the background makes it look like the menu is actually selected. A disabled menu should have the same background as normal, but the text should be greyed out, similar to the following from TSTool. The following also shows menu separators, which I mentioned in another issue.

image

@smalers smalers reopened this May 21, 2020
@Nightsphere
Copy link
Collaborator

New changes were made and pushed. As of now the menus are appearing the correct way whether
visible and/or enabled. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high Priority: next release if possible XS Size: 2 hours or less
Projects
None yet
Development

No branches or pull requests

2 participants