Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curtain characteristic warning #909

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Fix curtain characteristic warning #909

merged 1 commit into from
Feb 4, 2024

Conversation

dnicolson
Copy link
Collaborator

♻️ Current situation

The following error appears:

This plugin threw an error from the characteristic 'Hold Position': Characteristic Property 'minValue' can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info.
This plugin threw an error from the characteristic 'Hold Position': Characteristic Property 'maxValue' can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info.
This plugin threw an error from the characteristic 'Hold Position': Characteristic Property `minStep` can only be set for characteristics with numeric format, but not for bool. See https://homebridge.io/w/JtMGR for more info.

💡 Proposed solution

Remove the setProps call.

@donavanbecker
Copy link
Collaborator

please rebase with beta branch

@dnicolson dnicolson changed the base branch from latest to beta-3.1.1 February 4, 2024 15:50
@dnicolson dnicolson mentioned this pull request Feb 4, 2024
Closed
@donavanbecker donavanbecker merged commit 8fda94b into OpenWonderLabs:beta-3.1.1 Feb 4, 2024
6 of 7 checks passed
@donavanbecker donavanbecker mentioned this pull request Feb 5, 2024
Merged
donavanbecker added a commit that referenced this pull request Feb 5, 2024
@donavanbecker
3.1.1
066e62d 
## [3.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.1.1) (2024-02-05)

### What's Changed
- Fix BLE connection [#907](#907), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix BLE curtain mode [#908](#908), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix curtain characteristic warning [#909](#909), Thanks [@dnicolson](https://github.com/dnicolson)
- Revert curtain retry functionality [#911](#911), Thanks [@dnicolson](https://github.com/dnicolson)
- Code Cleaup [#910](#910) [#912](#912) [#913](#913)  [#917](#917), Thanks [@dnicolson](https://github.com/dnicolson)
- Housekeeping and updated dependencies.

**Full Changelog**: v3.1.0...v3.1.1
donavanbecker added a commit that referenced this pull request Feb 5, 2024
@donavanbecker
v3.1.1 (#918)
f0063b1 
## [3.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.1.1) (2024-02-05)

### What's Changed
- Fix BLE connection [#907](#907), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix BLE curtain mode [#908](#908), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix curtain characteristic warning [#909](#909), Thanks [@dnicolson](https://github.com/dnicolson)
- Revert curtain retry functionality [#911](#911), Thanks [@dnicolson](https://github.com/dnicolson)
- Code Cleaup [#910](#910) [#912](#912) [#913](#913)  [#917](#917), Thanks [@dnicolson](https://github.com/dnicolson)
- Housekeeping and updated dependencies.

**Full Changelog**: v3.1.0...v3.1.1
banboobee pushed a commit to banboobee/homebridge-switchbot that referenced this pull request Mar 2, 2024
@donavanbecker @banboobee
v3.1.1 (OpenWonderLabs#918)
2c61315 
- Fix BLE connection [OpenWonderLabs#907](OpenWonderLabs#907), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix BLE curtain mode [OpenWonderLabs#908](OpenWonderLabs#908), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix curtain characteristic warning [OpenWonderLabs#909](OpenWonderLabs#909), Thanks [@dnicolson](https://github.com/dnicolson)
- Revert curtain retry functionality [OpenWonderLabs#911](OpenWonderLabs#911), Thanks [@dnicolson](https://github.com/dnicolson)
- Code Cleaup [OpenWonderLabs#910](OpenWonderLabs#910) [OpenWonderLabs#912](OpenWonderLabs#912) [OpenWonderLabs#913](OpenWonderLabs#913)  [OpenWonderLabs#917](OpenWonderLabs#917), Thanks [@dnicolson](https://github.com/dnicolson)
- Housekeeping and updated dependencies.

**Full Changelog**: OpenWonderLabs/homebridge-switchbot@v3.1.0...v3.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnicolson @donavanbecker