Fix node-switchbot import #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just worked through an issue that I found and have pushed to node-switchbot beta. |
donavanbecker
added a commit
that referenced
this pull request
Feb 10, 2024
## [3.3.0](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.3.0) (2024-02-09) ### What's Changed - Add config that allows you to set `cool` and `heat`: `min` & `max` - Fix node-switchbot import [#928](#928), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove unnecessary await keyword [#929](#929), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove empty image tag [#930](#930), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v3.2.0...v3.3.0
Merged
donavanbecker
added a commit
that referenced
this pull request
Feb 10, 2024
## [3.3.0](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.3.0) (2024-02-09) ### What's Changed - Add config that allows you to set `cool` and `heat`: `min` & `max` - Fix node-switchbot import [#928](#928), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove unnecessary await keyword [#929](#929), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove empty image tag [#930](#930), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: v3.2.0...v3.3.0
banboobee
pushed a commit
to banboobee/homebridge-switchbot
that referenced
this pull request
Mar 2, 2024
- Add config that allows you to set `cool` and `heat`: `min` & `max` - Fix node-switchbot import [OpenWonderLabs#928](OpenWonderLabs#928), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove unnecessary await keyword [OpenWonderLabs#929](OpenWonderLabs#929), Thanks [@dnicolson](https://github.com/dnicolson) - Code cleanup: Remove empty image tag [OpenWonderLabs#930](OpenWonderLabs#930), Thanks [@dnicolson](https://github.com/dnicolson) - Housekeeping and updated dependencies. **Full Changelog**: OpenWonderLabs/homebridge-switchbot@v3.2.0...v3.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
💡 Proposed solution
Import the module correctly and stop unnecessarily importing
noble. The latter was a workaround for what was fixed in OpenWonderLabs/node-switchbot#221.There are still issues with
node-switchbotdue to (at least) the static declaration ofgetDeviceObjectwhich causesthis.nobleto be undefined:https://github.com/OpenWonderLabs/node-switchbot/blob/7a8e59ce395cda608b2e5b4dbd571dac47d9f1b1/src/switchbot.ts#L263
Do you have any ideas @donavanbecker? Have any of these 3.x.x releases worked for you with BLE?