fix reversed bot state reporting

[grelca]

♻️ Current situation

closes #206
bot state is being reported backwards, the bot broadcasts 0 when when bot switch is on and 1 when it is off.

💡 Proposed solution

update the advertising parser to recognize a bit value of 0 as the switch state being on, and a value of 1 as the switch state being off.

⚙️ Release Notes

Fixes an issue where SwitchBot bot state was reported incorrectly.

Testing

don't see any automated test framework to add to or update, but validated state was reported correctly in node repl that state value was reported correctly

testing output

bot started off, i toggled it on then off during test. state was reported correctly each time

> var switchbot = require('./lib/switchbot')
undefined
> var s = new switchbot()
undefined
> s.onadvertisement = console.log
[Function: log]
> s.startScan({ model: 'H' })
Promise {
  <pending>,
  [Symbol(async_id_symbol)]: 243,
  [Symbol(trigger_async_id_symbol)]: 6
}
> {
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -63,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -68,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -63,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -62,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -70,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -71,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -65,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -66,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -66,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -66,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -76,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -76,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -65,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -66,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -76,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -69,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 98
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -69,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: true,
    battery: 100
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -61,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: true,
    battery: 100
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -61,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: true,
    battery: 100
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -61,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -64,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -64,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -71,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -64,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}
{
  id: '265d16762bc91643c2ea93c9cc2b6a4f',
  address: 'ff:47:4d:2e:de:28',
  rssi: -64,
  serviceData: {
    model: 'H',
    modelName: 'WoHand',
    mode: true,
    state: false,
    battery: 99
  }
}

[donavanbecker]

Thanks!

[donavanbecker]

I will get this into a homebridge-switchbot plugin as soon as i have time.