Removal of weapon attachments when upgrading weapons

[Mortecha]

This is more of an issue to discuss a behavior in the game and make note of it for future reference if it does successfully be determined as a bug and does get fixed someday. This isn't a demand from someone with no skin in the game yet to expect to be fixed straight away.

Describe the bug
When upgrading weapons, after an upgrade has been applied, all weapon attachments are removed from the weapon and placed in the inventory. The player must then manually reattach the removed attachments. This behavior has been observed in COP, COP with OpenXRay and Anomaly. Behavior in CS and CS with OpenXRay is currently untested but is a safe assumption that it exists there as well.

The bug also occurs regardless if the weapon being upgraded is currently equipped in an equipment slot, or if it resides in the player's inventory.

To Reproduce
Steps to reproduce the behavior:

1. Posses an upgradable weapon with attachments attached onto it. A scope and suppressor on an assault rifle for example.
2. Upgrade the weapon through a technician
3. Notice the attachments are removed and placed in the inventory

Expected behavior
Attachments remain attached to the weapon they have been attached to after the upgrade has been completed.

Desktop (please complete the following information):

• OS: Windows 10
• OpenXRay

Additional context
This is one of those things in the game that can be lived with but seem counter intuitive and present only a minor annoyance to the grand experience of the games for the player so is more of a low hanging fruit that improves the user experience.

However if the player has attached an attachment to the weapon, the game should respect the players decision to have attached the attachment. For ("Rolplaying") sake, if the upgrades required the removal of the attachments to perform the upgrade, the technician would then reattach the attachments after they have completed their task.

In the end, this change also respects OpenXRay's direction to remain as vanilla as possible as well as something that wouldn't need to be optionally selected by the player.

[Xottab-DUTY]

This is not a bug, it's a gameplay feature.

[Mortecha]

Its funny because in software development, any bug could be considered a feature:P I kid though.

I see, Would it be an acceptable solution to seek to have this behavior changed and would such a change be accepted and liked if you will.

[Xottab-DUTY]

When you give your gun to a gunsmith in real life, he will disassemble (completely or partially) your weapon into parts to be able to upgrade.

And the next point is when this feature becomes questionable:

1. Upgrading takes time, so you dismount all your scopes, silencers and give your bare gun to a gunsmith so it can be upgraded and just heading to your home, etc. with your weapon attachments in the bag.
2. You could give your gun with scope, etc. and gunsmith will have to dismount attachments himself to upgrade a gun. It's just not polite when he doesn't attach them back.

So, in terms of a gameplay this feature looks unfinished or something like that. It would be more logical and interesting to make some improvements to this behaviour:
Depending on character personality mechanic would:

1. Take a gun with attachments, dismount them and mount them himself.
2. Won't take a gun until you dismount everything yourself with phrase something like: "hey, dismount your scopes, silencers, etc. I'm not going to store them in my workshop, I'm taking only bare metal gun."
   2.1. Will take a gun and dismount attachments, but still won't store them in his workshop, giving them to your inventory.
3. Will take price for storing your belongings in his workshop.

And this could even more improved with variety:

1. Sometimes mechanic will have a bad mood, so it will dismount attachments himself, but won't mount them back saying: "Nah, I'm lazy, attach it yourself" and throwing that cool tactical scope right in your face :D
2. The price for storing items would be different accordingly to player's reputation.

[Mortecha]

When they throw the scope at you you should take damage and begin bleeding:P

Jokes aside,

From a gameplay perspective. I think just leaving them attached on the weapon would suffice:P So 1. "Take a gun with attachments, dismount them and mount them himself." would be desired. The path of least resistance is you will, saves having to rummage through your inventory to find and reattach them again and saves afew click and drags.

[Hrusteckiy]

As you wish, you can make it by option, lol.

[Mortecha]

Thanks for pointing me in the right direction, still getting familiar with the source so would have taken me a while to find it:)

[Mortecha]

What makes this behavior more inconsistent is that repairing a weapon with attachments doesn't remove the attachments.

I've made the changed necessary but am testing them all currently, still trying to get the whole building the project and seeing the changes thing to work. It will take a little while.