VSock: Initial datagram implementation for Argo. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dozylynx
requested changes
May 1, 2019
There was a problem hiding this comment.
I'm very happy to see this initial driver -- thanks for putting it together (with documentation, very nice!). It looks well structured and like a good starting point.
I have some minor feedback points below - nothing heavy. I have not tested this driver yet but it builds fine.
v2
|
v3
|
dozylynx
requested changes
Jun 25, 2019
Based on Xen 4.12.0 released headers. An Argo implementation for VSock for datagram transfers. Support basic packet communication across domains. Rings are registered at socket naming (bind(3p)). There is one ring created per partner in the domain. This includes ANY, which Xen will allow only in mac-permissive mode for Argo. Send is synchronous: does an hypercall directly, like V4V used to do. Recv is handled in a tasklet that will make skbs with data recovered from the ring. Ring size is hardcoded to 32 pages currently. Signed-off-by: Eric Chanudet <chanudete@ainfosec.com> OXT-1473
V4
|
dozylynx
requested changes
Jun 25, 2019
added 2 commits
June 26, 2019 11:42
Very simple tool to send/recv things through VSock.
Basic usage:
hatch domid port
hatch -r -p local_port
Options:
-r, --recv receive mode, wait for incoming packets.
-p, --port set local port number.
-D enable debug output on stderr.
Debug is logged on stderr to allow stdout redirection.
If vsock_argo_transport.ko was not loaded, vmw_vsock_vmci_transport.ko
will likely be loaded by default (depends on the installation). You need
to remove vmw_vsock_vmci_transport.ko before you can load
vsock_argo_transport.ko again.
Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
OXT-1473
Walk through how to test VSock/Argo. Signed-off-by: Eric Chanudet <chanudete@ainfosec.com>
v5
|
|
Builds clean now. Merging. |
Tmcg2
pushed a commit
to Tmcg2/linux-xen-argo
that referenced
this pull request
Jun 4, 2020
…ux-xen-argo:openxt_master_merge to master * commit '11866bceac9974f6f688e84b8a6116e8d9c65675': argo-module: constify iov pointer argo-module: unused variable in kernel <4.19 argo-module: Linux 5.0 access_ok() stub argo-linux: Implicit fall through argo-linux: use init_pseudo for vfs argo-linux: suppress SMAP warnings vsock: suppress SMAP warnings gitignore: Remove top-level libargo: Amend gitignore vsock-argo: Add built-in objects to gitignore argo-linux: Add built-in objects to gitignore argo-modules: Put some printks behind ARGO_DEBUG Try to auto-bind to the partner's domid README: Initial documentation. vsock/test: Netcat-like utility for Argo DGRAM. vsock/module: Initial datagram implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An out-of-tree module for VSock DGRAM over Argo.
Based on headers released with Xen 4.12.
A copy of Xen
argo.hheader is added to the out-of-tree module to ease the compilation process against existing kernel headers, since it is not shipped as part of Linux headers.Also re-introduce
hypercall5inargo-compat.h, removed from upstream as it was no longer used, see comments in the header.Add a test utility for VSock/Argo DGRAM transfers
Simple test tool to send/recv things over VSock through Argo and ease testing. It tries to mimic
netcatusage to not look too unfamiliar.socatshould be able to achieve the same, with a steeper learning curve. This will be made easier once STREAM communication are implemented I would think.Provide instructions in a README
Add some instruction on how to test VSock/Argo on existing Xen 4.12.y installations. Try to address caveats that may be encountered and provide some details as to what is this all about.