Ufopaedia extended, Interface classes Text and TextList #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look fine, although a "condensed TextList" is pretty much the same as multiple Text's, but I get it, you wanna be lazy. :P I'll look it over and see if it broke anything. I would've preferred if you kept the Mac files out though, since it's a lot of stuff that doesn't belong in the codebase (external dependencies etc.) and I can't really keep the XCode project files updated so they'd confuse people. |
SupSuper
pushed a commit
that referenced
this pull request
Oct 20, 2013
redv
pushed a commit
to redv/OpenXcom
that referenced
this pull request
Sep 30, 2014
Feature: radarChance of aircraft's radars.
Warboy1982
pushed a commit
that referenced
this pull request
Nov 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I extended Text (featuring getTextWidth) where I don't see any problem.
The TextList extensions go further and I don't know if this is right there or if an extra StaticTextList or whatever should be made.
For craft articles, I added the "condensed" feature and for craft weapons, I added "setBig". I didn't test these features with interactive or scrollable lists, so please review and tell me what you think about it...
Cheers,
Guido