Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing of MemBlock #3140

Merged
merged 10 commits into from
Jul 11, 2024
Merged

Fix timing of MemBlock #3140

merged 10 commits into from
Jul 11, 2024

Conversation

weidingliu
Copy link
Contributor

No description provided.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0f3af01

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0f3af01 1.805 0.458 2.004 1.189 2.922 2.498 2.223 0.924 1.392 1.405 3.162 2.653 2.401 2.959

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
4c8a449
182b7ec 1.805 0.458 2.004 1.189 2.922 2.498 2.224 0.924 1.355 1.405 3.162 2.653 2.401 2.959
18179bb 1.805 0.458 2.004 1.189 2.922 2.498 2.223 0.924 1.355 1.405 3.162 2.653 2.401 2.959
a13f171 1.805 0.458 2.004 1.189 2.922 2.498 2.224 0.924 1.358 1.405 3.162 2.653 2.401 2.959
b9631a8 1.805 0.458 2.004 1.189 2.922 2.498 2.224 0.924 1.378 1.405 3.162 2.653 2.401 2.959
d4119b5 1.805 0.458 1.995 1.189 2.928 2.494 2.224 0.927 1.356 1.389 3.173 2.664 2.401 2.963
136b9ac 1.804 0.458 1.995 1.189 2.928 2.494 2.224 0.927 1.358 1.389 3.173 2.664 2.401 2.963
b4f1e5b 1.804 0.458 1.995 1.189 2.928 2.494 2.224 0.927 1.393 1.389 3.173 2.664 2.401 2.963
ecc992c 1.804 0.458 1.995 1.189 2.928 2.494 2.224 0.927 1.358 1.389 3.173 2.664 2.401 2.963
4c0e018 1.805 0.458 1.995 1.189 2.928 2.494 2.226 0.927 1.356 1.389 3.173 2.664 2.401 2.963

@weidingliu weidingliu marked this pull request as ready for review July 4, 2024 02:26
@weidingliu weidingliu force-pushed the memblock-fix-timing-0621 branch 5 times, most recently from 86019ca to 0632a7d Compare July 9, 2024 08:35
@Anzooooo Anzooooo mentioned this pull request Jul 10, 2024
Closed
@weidingliu
VSplit: Optimised address generation
c08491c
@weidingliu
VSegmentUnit: refactor generate of writeback exceptionVec
6335d42 
For now, exception only handle when all of the uops writeback, don't need let last writeback uop raise exception
weidingliu and others added 8 commits July 11, 2024 12:56
@weidingliu
VMergeBuffer: delay 1 cycle to writeback backend for better timing
ac2d29f
@weidingliu
VSplit: refactor enter MergeBuffer handshark logic
bad719c
@good-circle @weidingliu
MemBlock: remove VLSU RS ready rely on isSegment
ee63b55
@weidingliu
VMergeBuffer: add ExceptionVec select By fuCfg for better timing and …
ac2c1e9 
…area
@weidingliu
MemBlock: fix bug for arbiter of vector load/store uopwriteback
47eb2b6
@weidingliu
VSplit: refactor addr aligned logic for Unit-Stride
1a5e38a
@weidingliu
LoadUnit: fix bug of uncacheBuffer writeback
35dab3f 
In the previous design, when loadUnit s3 have invalid flag of isVec, uncacheBuffer can't writeback to backend. This commit fix it
@weidingliu
MemBlock: refactor selectOldest of rollback for better timing
cebe44b 
Don't select oldest rollback twice in LoadQueueRAW,  send to memblock select oldest with other, will have  port to send rollback request to memblock in LoadQueueRAW.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: cebe44b

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
cebe44b 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
11d5798
db00024
1d2f6c6 2.003 1.374
94d703a 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
47986d3 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
38f78b5 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
e6ac7fe 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
ec15951 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
dab1ad8 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956
c6655c9 1.784 0.458 2.003 1.199 2.920 2.498 2.207 0.928 1.374 1.441 3.153 2.600 2.385 2.956

@Tang-Haojin Tang-Haojin merged commit 16ede6b into OpenXiangShan:master Jul 11, 2024
7 checks passed
@weidingliu weidingliu deleted the memblock-fix-timing-0621 branch July 12, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjuanZ linjuanZ linjuanZ approved these changes

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@weidingliu @XiangShanRobot @linjuanZ @Tang-Haojin @good-circle