This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Update devices.js #545
Merged
Update devices.js #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Honeywell 39358 Fan Control so it will be discovered as a fan an not a light.
chilicheech
reviewed
Jun 1, 2020
hass/devices.js
Outdated
| @@ -183,6 +183,7 @@ module.exports = { | |||
| '2-40976-266': [DANFOSS_TRV_ZWAVE], // Popp Radiator Thermostat | |||
| '99-12340-18756': [FAN_DIMMER], // GE 1724 Dimmer | |||
| '99-12593-18756': [FAN_DIMMER], // GE 1724 Dimmer | |||
| '57-12593-18756': [FAN_DIMMER], // Honeywell 39358 In-Wall Fan Control | |||
There was a problem hiding this comment.
please order this list alphanumerically. this entry should go above the 2 GE dimmers since the id starts with 57 which comes before 99
There was a problem hiding this comment.
Updated in the correct order.
|
LGTM, thanks @jasonsinclair5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Honeywell 39358 Fan Control so it will be discovered as a fan an not a light.