Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

[devices] Add Intermatic PE653 MultiWave Receiver #618

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

j9brown
Copy link
Contributor

@j9brown j9brown commented Jul 3, 2020

This change depends on the following patch to OpenZWave: OpenZWave/open-zwave#2289

@robertsLando
Copy link
Member

Why did you added the switchs too? Aren’t them automatically discovered?

@j9brown
Copy link
Contributor Author

j9brown commented Jul 3, 2020 via email

@robertsLando
Copy link
Member

Could you fix lint errors? Just run npm run lint-fix

@j9brown
Copy link
Contributor Author

j9brown commented Jul 4, 2020 via email

// Intermatic PE653 MultiWave Receiver
{
type: 'climate',
object_id: 'pool_thermostat',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use more generic names? Is this device usually used to create this entities or is just for your use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names used by the device itself, see next comment.

},
{
type: 'climate',
object_id: 'spa_thermostat',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Then seems this are configured in the same way so you will have 2 thermostats that controls same values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually two thermostat instances, 67-1-1 and 67-1-7 but curiously only one water temperature sensor 49-1-1 that is used for both. The thermostats have dedicated functions in the system. One thermostat is used specifically for Pool temperature and the other for Spa temperature and they are labeled as such in the UI.

There's also support for air temperature and freeze sensors as well as some other auxiliary equipment I don't have, so that can be added by someone else later. More information here if you're curious: https://www.intermatic.com/-/media/inriver/7092-8536.ashx

@robertsLando
Copy link
Member

@j9brown News on this?

@j9brown
Copy link
Contributor Author

j9brown commented Jul 10, 2020 via email

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit 7fe91b5 into OpenZWave:master Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants