This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: parse value functions #739 #741
feat: parse value functions #739 #741
Changes from 4 commits
43851b6
044dcd1
c160212
d3dbe84
f6c66ea
77446dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is returning
null
on failure better than returning the original value?can you return a promise? does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works in this way (I have tested this with a real device). I would not return a promise as the conversion function should be fast.
I could return the original value when it fails but I think this makes the code more readable, I mean If I return the original value, by reading the code seems that the function has return that value. What do you think it's better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
promises can be fast, the question is to whether it has to be sync or can it be async.
either is probably fine, but i'd make that clear in the gui that it must be a syncronis response.
theres technically no reason not to do async/promises, but i'm sure it could introduce all sorts of peculiar race conditions
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.