Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

fix: implement more environment variables for configuration #788

Merged
merged 6 commits into from
Oct 15, 2020
Merged

fix: implement more environment variables for configuration #788

merged 6 commits into from
Oct 15, 2020

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Oct 14, 2020 •
edited

Allows more zwave settings to be declared via environment variables

  • OZW_SAVE_CONFIG
  • OZW_POLL_INTERVAL
  • OZW_AUTO_UPDATE_CONFIG
  • OZW_CONFIG_PATH
  • OZW_ASSUME_AWAKE

@onedr0p onedr0p changed the title allow envars for all main zwave settings Implement Envars for configuration Oct 14, 2020
@onedr0p onedr0p changed the title Implement Envars for configuration Implement more environment variables for configuration Oct 14, 2020
@onedr0p onedr0p marked this pull request as ready for review October 14, 2020 15:17
@onedr0p
Copy link
Contributor Author

onedr0p commented Oct 14, 2020

Not sure what the issue is in the CI

@robertsLando
Copy link
Member

Run npm run lint-fix

@onedr0p onedr0p changed the title Implement more environment variables for configuration fix: implement more environment variables for configuration Oct 14, 2020
@onedr0p
Copy link
Contributor Author

onedr0p commented Oct 14, 2020 •
edited

I am having some silly issues with xcode, node and gyp. I'll try again later.

image

@onedr0p
Copy link
Contributor Author

onedr0p commented Oct 14, 2020

What a weird line change, this is ready to be reviewed.

robertsLando
robertsLando suggested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add docs about env vars please?

Add a section on readme named Environment variables

@onedr0p
Copy link
Contributor Author

onedr0p commented Oct 15, 2020

Envar section added 👍

robertsLando
robertsLando approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit d7bdb2c into OpenZWave:master Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onedr0p @robertsLando