Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate message logic ignores message length #2587

Open
rrozema opened this issue Feb 22, 2021 · 0 comments
Open

duplicate message logic ignores message length #2587

rrozema opened this issue Feb 22, 2021 · 0 comments

Comments

@rrozema
Copy link
Contributor

rrozema commented Feb 22, 2021

In Driver::HandleApplicationCommandHandlerRequest a check exists that looks to ignore duplicate messsages. This check always compares the full buffer length (254 bytes) to see if the message received is a duplicate of the last message, whereas the length of the actual messages varies and thus the buffer may still contain bytes left over from previous messages. Effectively the comparison may fail to detect a duplicate because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant